[PATCH] D90300: [flang][driver] Rename the accessors (NFC)

Andrzej Warzynski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 28 04:50:36 PDT 2020


awarzynski created this revision.
Herald added a reviewer: sscalpone.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
awarzynski requested review of this revision.

As per:

- https://github.com/llvm/llvm-project/blob/master/flang/docs/C++style.md#naming

point 3:

  Accessor member functions are named with the non-public data member's
  name, less the trailing underscore.

Originally we just followed the LLVM's style, which is incompatible with
Flang. This patch renames the accessors (and a handful of mutators)
accordingly.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D90300

Files:
  flang/include/flang/Evaluate/expression.h
  flang/include/flang/Frontend/CompilerInstance.h
  flang/include/flang/Frontend/CompilerInvocation.h
  flang/include/flang/Frontend/FrontendAction.h
  flang/include/flang/Frontend/FrontendOptions.h
  flang/lib/Evaluate/expression.cpp
  flang/lib/Frontend/CompilerInstance.cpp
  flang/lib/Frontend/CompilerInvocation.cpp
  flang/lib/Frontend/FrontendAction.cpp
  flang/lib/Frontend/FrontendActions.cpp
  flang/lib/FrontendTool/ExecuteCompilerInvocation.cpp
  flang/lib/Semantics/program-tree.cpp
  flang/lib/Semantics/program-tree.h
  flang/lib/Semantics/resolve-names.cpp
  flang/tools/flang-driver/fc1_main.cpp
  flang/unittests/Frontend/CompilerInstanceTest.cpp
  flang/unittests/Frontend/InputOutputTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D90300.301243.patch
Type: text/x-patch
Size: 16022 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201028/bfddda9d/attachment.bin>


More information about the llvm-commits mailing list