[PATCH] D90253: [WebAssembly] Prototype extending multiplication SIMD instructions
Heejin Ahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 28 04:01:45 PDT 2020
aheejin accepted this revision.
aheejin added inline comments.
This revision is now accepted and ready to land.
================
Comment at: llvm/include/llvm/IR/IntrinsicsWebAssembly.td:263
+// TODO: Add a new LLVMMatchType that can describe the relationship between the
+// result and parameter types here.
+def int_wasm_extmul_low_signed :
----------------
It [[ https://github.com/llvm/llvm-project/blob/419168d9381959ec6850e9e87aff9d062b68ef4b/llvm/include/llvm/IR/Intrinsics.td#L221 | seems ]] there is one already?
================
Comment at: llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCCodeEmitter.cpp:72
+ OS << uint8_t(Binary >> 16);
+ encodeULEB128(uint16_t(Binary), OS);
+ } else {
----------------
`encodeULEB128` isn't capable of encoding numbers larger than or equal to 256?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90253/new/
https://reviews.llvm.org/D90253
More information about the llvm-commits
mailing list