[PATCH] D90296: [AMDGPU] Allow some modifiers on VOP3B instructions

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 28 04:01:21 PDT 2020


foad created this revision.
foad added reviewers: dp, rampitec, arsenm.
Herald added subscribers: llvm-commits, kerbowa, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl.
Herald added a project: LLVM.
foad requested review of this revision.
Herald added a subscriber: wdng.

V_DIV_SCALE_F32/F64 <https://reviews.llvm.org/F64> are VOP3B encoded so they can't use the ABS src
modifier, but they can still use NEG and the usual output modifiers.

This partially reverts 3b99f12a4e6f "AMDGPU: Remove modifiers from v_div_scale_*".


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D90296

Files:
  llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp
  llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
  llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.h
  llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
  llvm/lib/Target/AMDGPU/SIISelLowering.cpp
  llvm/lib/Target/AMDGPU/SIInstrInfo.cpp
  llvm/lib/Target/AMDGPU/VOP3Instructions.td
  llvm/test/CodeGen/AMDGPU/fdiv-nofpexcept.ll
  llvm/test/CodeGen/AMDGPU/inserted-wait-states.mir
  llvm/test/CodeGen/AMDGPU/llvm.amdgcn.div.scale.ll
  llvm/test/CodeGen/AMDGPU/sched-crash-dbg-value.mir
  llvm/test/MC/AMDGPU/vop3-errs.s
  llvm/test/MC/AMDGPU/vop3.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D90296.301227.patch
Type: text/x-patch
Size: 22590 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201028/5e4c5667/attachment.bin>


More information about the llvm-commits mailing list