[PATCH] D90295: [yaml2obj] - Improve handling of SectionHeaderTable::NoHeaders flag.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 28 03:57:30 PDT 2020


grimar created this revision.
grimar added reviewers: jhenderson, MaskRay.
Herald added subscribers: rupprecht, hiraditya, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.
grimar requested review of this revision.

When `NoHeaders` is set, we still have following issues:

1. We emit the `.shstrtab` implicit section of size 1 (empty string table).
2. We still align the start of the section header table, what affects the output size.
3. We still write section header table bytes.

This patch fixes all of these issues.


https://reviews.llvm.org/D90295

Files:
  llvm/lib/ObjectYAML/ELFEmitter.cpp
  llvm/test/tools/llvm-readobj/ELF/malformed-pt-dynamic.test
  llvm/test/tools/yaml2obj/ELF/section-headers.yaml

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D90295.301223.patch
Type: text/x-patch
Size: 10001 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201028/db29f459/attachment-0001.bin>


More information about the llvm-commits mailing list