[PATCH] D89968: [SVE][InstCombine] Fix TypeSize warning in canReplaceGEPIdxWithZero

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 28 03:16:35 PDT 2020


sdesmalen added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/gep-can-replace-gep-idx-with-zero-typesize.ll:1
+; RUN: opt -S -O2 -mtriple=aarch64-linux-gnu -mattr=+sve < %s 2>%t
+; RUN: FileCheck --check-prefix=WARN --allow-empty %s <%t
----------------
You should make the tests more specific than running with `-O2` because it is not explicitly defined what passes are run at `-O2`  In this case you're fixing InstCombine, so the test should use `opt -S -instcombine`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89968/new/

https://reviews.llvm.org/D89968



More information about the llvm-commits mailing list