[PATCH] D89949: [yaml2obj][obj2yaml] - Teach tools to work with regular archives.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/tools/obj2yaml/archive2yaml.cpp:39
+            std::errc::illegal_byte_sequence,
+            "unable to read the header of a child at 0x%" PRIx64, Offset);
+
----------------
I think the "at offset" bit is necessary, as otherwise it's not immediately clear what the number represents (it might be an index for example). Same applies below.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89949/new/

https://reviews.llvm.org/D89949