[PATCH] D90289: [llvm-exegesis] Do not silently fail on unknown instruction encoding formats.

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 28 02:07:23 PDT 2020


This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG7e2ffe7a6358: [llvm-exegesis] Do not silently fail on unknown instruction encoding formats. (authored by courbet).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90289/new/

https://reviews.llvm.org/D90289

Files:
  llvm/tools/llvm-exegesis/lib/X86/Target.cpp


Index: llvm/tools/llvm-exegesis/lib/X86/Target.cpp
===================================================================
--- llvm/tools/llvm-exegesis/lib/X86/Target.cpp
+++ llvm/tools/llvm-exegesis/lib/X86/Target.cpp
@@ -53,7 +53,7 @@
 static const char *isInvalidMemoryInstr(const Instruction &Instr) {
   switch (Instr.Description.TSFlags & X86II::FormMask) {
   default:
-    llvm_unreachable("Unknown FormMask value");
+    return "Unknown FormMask value";
   // These have no memory access.
   case X86II::Pseudo:
   case X86II::RawFrm:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D90289.301202.patch
Type: text/x-patch
Size: 540 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201028/2f65b244/attachment.bin>


More information about the llvm-commits mailing list