[PATCH] D89432: [llvm-elfabi] Emit ELF .dynsym and .dynamic sections

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

I have no more comments (added a minor nit).

In D89432#2357600 <https://reviews.llvm.org/D89432#2357600>, @haowei wrote:

> I thought the attachment to the parent revision would be automatic. I have manually attached the parent revision to this diff.

It can be automatic if you add the following line to the patch description when posting:
"Depends on D<patchid>". E.g. "Depends on D61767 <https://reviews.llvm.org/D61767>" in this case.



================
Comment at: llvm/lib/InterfaceStub/ELFObjHandler.cpp:112
+    Elf_Sym S{};
+    Symbols.push_back(S);
+  }
----------------
nit: you should be able to do:
```
Symbols.push_back({});
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89432/new/

https://reviews.llvm.org/D89432