[compiler-rt] 58828f6 - [NFC][UBSAN] Remove XFAIL from fixed tests

[Roman Lebedev via llvm-commits]

Nice. Can you say what fixed them?

Roman

On Wed, Oct 28, 2020 at 9:44 AM Vitaly Buka via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
>
>
> Author: Vitaly Buka
> Date: 2020-10-27T23:43:50-07:00
> New Revision: 58828f6a93cd290cde2bf657a7c96a7399a328c1
>
> URL: https://github.com/llvm/llvm-project/commit/58828f6a93cd290cde2bf657a7c96a7399a328c1
> DIFF: https://github.com/llvm/llvm-project/commit/58828f6a93cd290cde2bf657a7c96a7399a328c1.diff
>
> LOG: [NFC][UBSAN] Remove XFAIL from fixed tests
>
> Added:
>
>
> Modified:
>     compiler-rt/test/ubsan/TestCases/ImplicitConversion/integer-sign-change-blacklist.c
>     compiler-rt/test/ubsan/TestCases/ImplicitConversion/signed-integer-truncation-blacklist.c
>     compiler-rt/test/ubsan/TestCases/ImplicitConversion/signed-integer-truncation-or-sign-change-blacklist.c
>     compiler-rt/test/ubsan/TestCases/ImplicitConversion/unsigned-integer-truncation-blacklist.c
>
> Removed:
>
>
>
> ################################################################################
> diff  --git a/compiler-rt/test/ubsan/TestCases/ImplicitConversion/integer-sign-change-blacklist.c b/compiler-rt/test/ubsan/TestCases/ImplicitConversion/integer-sign-change-blacklist.c
> index c51296e2213c..8acc516fcaf1 100644
> --- a/compiler-rt/test/ubsan/TestCases/ImplicitConversion/integer-sign-change-blacklist.c
> +++ b/compiler-rt/test/ubsan/TestCases/ImplicitConversion/integer-sign-change-blacklist.c
> @@ -1,6 +1,3 @@
> -// FIXME: https://code.google.com/p/address-sanitizer/issues/detail?id=316
> -// I'm not sure this is actually *that* issue, but this seems oddly similar to the other XFAIL'ed cases.
> -// XFAIL: android
>  // UNSUPPORTED: ios
>
>  // RUN: %clang -fsanitize=implicit-integer-sign-change -fno-sanitize-recover=implicit-integer-sign-change                           -O0 %s -o %t && not %run %t 2>&1 | FileCheck %s --implicit-check-not="implicit conversion"
>
> diff  --git a/compiler-rt/test/ubsan/TestCases/ImplicitConversion/signed-integer-truncation-blacklist.c b/compiler-rt/test/ubsan/TestCases/ImplicitConversion/signed-integer-truncation-blacklist.c
> index 1d1fe4ba1259..4598fb2e2a99 100644
> --- a/compiler-rt/test/ubsan/TestCases/ImplicitConversion/signed-integer-truncation-blacklist.c
> +++ b/compiler-rt/test/ubsan/TestCases/ImplicitConversion/signed-integer-truncation-blacklist.c
> @@ -1,6 +1,3 @@
> -// FIXME: https://code.google.com/p/address-sanitizer/issues/detail?id=316
> -// I'm not sure this is actually *that* issue, but this seems oddly similar to the other XFAIL'ed cases.
> -// XFAIL: android
>  // UNSUPPORTED: ios
>
>  // RUN: %clang -fsanitize=implicit-integer-truncation -fno-sanitize-recover=implicit-integer-truncation                           -O0 %s -o %t && not %run %t 2>&1 | FileCheck %s --implicit-check-not="implicit conversion"
>
> diff  --git a/compiler-rt/test/ubsan/TestCases/ImplicitConversion/signed-integer-truncation-or-sign-change-blacklist.c b/compiler-rt/test/ubsan/TestCases/ImplicitConversion/signed-integer-truncation-or-sign-change-blacklist.c
> index 3c2a328ae9a0..e613f75c988d 100644
> --- a/compiler-rt/test/ubsan/TestCases/ImplicitConversion/signed-integer-truncation-or-sign-change-blacklist.c
> +++ b/compiler-rt/test/ubsan/TestCases/ImplicitConversion/signed-integer-truncation-or-sign-change-blacklist.c
> @@ -1,6 +1,3 @@
> -// FIXME: https://code.google.com/p/address-sanitizer/issues/detail?id=316
> -// I'm not sure this is actually *that* issue, but this seems oddly similar to the other XFAIL'ed cases.
> -// XFAIL: android
>  // UNSUPPORTED: ios
>
>  // All of these don't actually silence it:
>
> diff  --git a/compiler-rt/test/ubsan/TestCases/ImplicitConversion/unsigned-integer-truncation-blacklist.c b/compiler-rt/test/ubsan/TestCases/ImplicitConversion/unsigned-integer-truncation-blacklist.c
> index 6ee572dbc8a2..2927e4bb2b9c 100644
> --- a/compiler-rt/test/ubsan/TestCases/ImplicitConversion/unsigned-integer-truncation-blacklist.c
> +++ b/compiler-rt/test/ubsan/TestCases/ImplicitConversion/unsigned-integer-truncation-blacklist.c
> @@ -1,6 +1,3 @@
> -// FIXME: https://code.google.com/p/address-sanitizer/issues/detail?id=316
> -// I'm not sure this is actually *that* issue, but this seems oddly similar to the other XFAIL'ed cases.
> -// XFAIL: android
>  // UNSUPPORTED: ios
>
>  // RUN: %clang -fsanitize=implicit-integer-truncation -fno-sanitize-recover=implicit-integer-truncation                           -O0 %s -o %t && not %run %t 2>&1 | FileCheck %s --implicit-check-not="implicit conversion"
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits