[PATCH] D90288: [FPEnv] Allow strict SETCC falling back if strict FP is not supported.

Pengfei Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 27 23:42:00 PDT 2020


pengfei marked an inline comment as done.
pengfei added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:3772
+      // handing for target that only supports SELECT_CC.
+      assert("Expanding to SELECT_CC is not supported for strict nodes.");
+    }
----------------
craig.topper wrote:
> This assert doesn't do anything. The string is a non-null const char* so the assert will aways pass.
Thanks Craig.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90288/new/

https://reviews.llvm.org/D90288



More information about the llvm-commits mailing list