[PATCH] D90265: [llvm][StringExtras] Add a fail-able version of `fromHex` and optimize hex digit lookup

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 27 21:48:52 PDT 2020


phosek accepted this revision.
phosek added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/include/llvm/ADT/StringExtras.h:205
+  return true;
 }
+inline uint8_t hexFromNibbles(char MSB, char LSB) {
----------------
Nit: Can you leave an empty line between functions?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90265/new/

https://reviews.llvm.org/D90265



More information about the llvm-commits mailing list