[PATCH] D80695: [mlir] Convert raw data in dense element attributes for big-endian machines.
Haruki Imai via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 27 20:57:44 PDT 2020
imaihal added inline comments.
================
Comment at: mlir/lib/IR/Attributes.cpp:1128-1129
+
+ assert(llvm::support::endian::system_endianness() == // NOLINT
+ llvm::support::endianness::big); // NOLINT
+ // NOLINT to avoid warning message about replacing by static_assert()
----------------
Inserted `NOLINT` to avoid warning messages in clang-tidy. The warning message suggested to use `static_assert()` here, but it is not appropriate here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80695/new/
https://reviews.llvm.org/D80695
More information about the llvm-commits
mailing list