[PATCH] D84113: [Debuginfo] (1/8) [DW_OP_implicit_pointer/second strategy] Support for DW_OP_LLVM_implicit_pointer

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/docs/LangRef.rst:5189
+  represented by the ``DILocalVariable`` referred to by the instructions
+  value/address operand at offset N.
 
----------------
aprantl wrote:
> I think we could expand this a bit.
> - is it illegal in a DIGlobalVariableExpression?
> 
> Maybe include an example use?
I think this could really benefit from an example. Also, it is odd to refer to a DILocalVariable in the documentation of a DIExpression operand, since DIExpressions can be pointed to by dbg.values (which may bind them to one or more DILocalVariables) but they can also appear in other places. I understand that the DWARF definition of DW_OP_implicit_pointer makes some of this strangeness necessary, but we should do at least our best in documenting how this is supposed to be used.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84113/new/

https://reviews.llvm.org/D84113