[PATCH] D89845: Add the ability to extract the unwind rows from DWARF Call Frame Information.

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

Not an expert either, but at a high level this seems reasonable.



================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFDebugFrame.h:37
+  enum Location {
+    Unspecified,   // Not specified.
+    Undefined,     // Register is not available and can't be recovered.
----------------
nit:
```
/// Not specified.
Unspecified
...
```

Then it will show up in Doxygen.


================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFDebugFrame.h:56
+private:
+  Location Kind;   // The type of the location that describes how to unwind it.
+  uint32_t RegNum; // The register number for Kind == RegPlusOffset.
----------------
same for these comments


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp:370
+  switch (Type) {
+  case OT_Unset:
+    llvm_unreachable("OperandType OT_Unset has no value");
----------------
Just double-checking: Is this really unreachable, or should this be error handling?


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp:408
+  switch (Type) {
+  case OT_Unset:
+    llvm_unreachable("OperandType OT_Unset has no value");
----------------
same here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89845/new/

https://reviews.llvm.org/D89845