[PATCH] D88977: Reapply [ADT] function_ref's constructor is unavailable if the argument is not callable.

Stella Stamenova via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 27 18:39:07 PDT 2020


stella.stamenova added a comment.

In D88977#2356948 <https://reviews.llvm.org/D88977#2356948>, @sammccall wrote:

> Oh wow, I think those are different pointers to the same string, and MSVC+Debug is the only configuration that doesn't fold them together.
>
> So this is just a dumb bug in the test. I just pushed 1a1aad9156407bc891e2738e9877c03bd594e67f <https://reviews.llvm.org/rG1a1aad9156407bc891e2738e9877c03bd594e67f> which should fix it, please let me know if it doesn't!

Thanks! All good now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88977/new/

https://reviews.llvm.org/D88977



More information about the llvm-commits mailing list