[PATCH] D90278: [ThinLTO] Fix .llvmcmd emission

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 27 18:21:44 PDT 2020


mtrofin created this revision.
mtrofin added a reviewer: tejohnson.
Herald added subscribers: llvm-commits, cfe-commits, steven_wu, hiraditya, inglorion.
Herald added projects: clang, LLVM.
mtrofin requested review of this revision.

llvm::EmbedBitcodeInModule needs (what used to be called) EmbedMarker
set, in order to emit .llvmcmd. EmbedMarker is really about embedding the
command line, so renamed the parameter accordingly, too.

This was not caught at test because the check-prefix was incorrect, but
FileCheck does not report that when multiple prefixes are provided. A
separate patch will address that.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D90278

Files:
  clang/lib/CodeGen/BackendUtil.cpp
  clang/test/CodeGen/thinlto_embed_bitcode.ll
  llvm/include/llvm/Bitcode/BitcodeWriter.h
  llvm/include/llvm/LTO/LTOBackend.h
  llvm/lib/Bitcode/Writer/BitcodeWriter.cpp
  llvm/lib/LTO/LTOBackend.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D90278.301157.patch
Type: text/x-patch
Size: 8628 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201028/ba6d9ade/attachment.bin>


More information about the llvm-commits mailing list