[PATCH] D89158: [NewPM] Run all EP callbacks under -O0

Yuanfang Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 27 17:21:56 PDT 2020


ychen added inline comments.


================
Comment at: llvm/include/llvm/Passes/PassBuilder.h:626
+  /// typically run at the very beginning.
+  void runRegisteredO0EPCallbacks(ModulePassManager &MPM, bool DebugLogging);
+
----------------
invokeO0EPCallbacks? I saw there is `PassBuilder::invokePeepholeEPCallbacks`.


================
Comment at: llvm/lib/Passes/PassBuilder.cpp:1659
+                                             bool DebugLogging) {
+  for (auto &C : PipelineStartEPCallbacks)
+    C(MPM);
----------------
What I have in mind is a newly added `O0EPCallbacks` field in PassBuilder class. Then we can keep existing EPCallbacks (including PipelineStartEPCallbacks) for >O0 optimization pipeline. Yeah, then you need to add related passes to O0EPCallbacks (for BPF in this case).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89158/new/

https://reviews.llvm.org/D89158



More information about the llvm-commits mailing list