[llvm] 8752065 - Revert "[Docs] Clarify that FunctionPasses can't add/remove declarations"

[Arthur Eubanks via llvm-commits]

Sorry, I will be more diligent about that in the future.
For this specifically, see some discussion in
https://reviews.llvm.org/D89890.

On Tue, Oct 27, 2020 at 12:58 PM David Blaikie <dblaikie at gmail.com> wrote:

> It's good to include some details on why a patch is reverted in the patch
> description for context/readers/history.
>
> On Thu, Oct 22, 2020 at 9:50 AM Arthur Eubanks via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
>>
>> Author: Arthur Eubanks
>> Date: 2020-10-22T09:49:42-07:00
>> New Revision: 87520657b814227625149763ba750a56ae481448
>>
>> URL:
>> https://github.com/llvm/llvm-project/commit/87520657b814227625149763ba750a56ae481448
>> DIFF:
>> https://github.com/llvm/llvm-project/commit/87520657b814227625149763ba750a56ae481448.diff
>>
>> LOG: Revert "[Docs] Clarify that FunctionPasses can't add/remove
>> declarations"
>>
>> This reverts commit 710676cf3a3c6f6ddf2f18e24cac017d20dac1ff.
>>
>> Added:
>>
>>
>> Modified:
>>     llvm/docs/WritingAnLLVMPass.rst
>>
>> Removed:
>>
>>
>>
>>
>> ################################################################################
>> diff  --git a/llvm/docs/WritingAnLLVMPass.rst
>> b/llvm/docs/WritingAnLLVMPass.rst
>> index 5d8a9d645fa7..7a24659e6294 100644
>> --- a/llvm/docs/WritingAnLLVMPass.rst
>> +++ b/llvm/docs/WritingAnLLVMPass.rst
>> @@ -474,8 +474,7 @@ external functions.
>>  To be explicit, ``FunctionPass`` subclasses are not allowed to:
>>
>>  #. Inspect or modify a ``Function`` other than the one currently being
>> processed.
>> -#. Add or remove ``Function``\ s from the current ``Module``, including
>> -   declarations.
>> +#. Add or remove ``Function``\ s from the current ``Module``.
>>  #. Add or remove global variables from the current ``Module``.
>>  #. Maintain state across invocations of :ref:`runOnFunction
>>     <writing-an-llvm-pass-runOnFunction>` (including global data).
>>
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201027/aad8a262/attachment.html>