[PATCH] D90106: [JumpThreading] Set edge probabilities when creating basic blocks

Tue Oct 27 16:11:17 PDT 2020

kazu added a comment.

In D90106#2355030 <https://reviews.llvm.org/D90106#2355030>, @wmi wrote:

>> Do you know whether we have missed some BranchProbabilityInfo::eraseBlock calls? Why is BasicBlockCallbackVH::deleted() not effective when some BasicBlock's are removed?
>
> Same question here. There shouldn't be stale value in Prob if the value handler is functioning correctly.

Please see the description of the follow-up patch I just posted: https://reviews.llvm.org/D90272

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90106/new/

https://reviews.llvm.org/D90106