[PATCH] D90268: [NFC] Use Register in RegisterPressure APIs

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin marked an inline comment as done.
mtrofin added a comment.

In D90268#2357684 <https://reviews.llvm.org/D90268#2357684>, @MaskRay wrote:

> My understanding is that MCRegister values take a subset [0,2**30). In some cases MCRegister is more suitable than Register. Have you checked whether some places should use MCRegister instead?

Yes - that's part of the focus of these refactorings - i.e. using Register / MCRegister appropriately (instead of unsigned). My approach has been to look at how the value was used. In these cases, it appears the value may be virtual - because there were checks to that extent. Having said that, it is possible there are cases where those checks were themselves redundant (i.e. should / could have been asserts before). Maybe I missed something, I'll take another look.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90268/new/

https://reviews.llvm.org/D90268