[PATCH] D90261: [lld][WebAssembly] Fix memory size in dylink section for -pie exectuables

Alon Zakai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 27 15:26:22 PDT 2020


kripken accepted this revision.
kripken added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lld/wasm/Writer.cpp:299
+  if (config->isPic) {
+    out.dylinkSec->memSize = memoryPtr - dataStart;
     return;
----------------
`memoryPtr - dataStart` also appears on line 296, maybe worth a lccal variable? (I'm not sure of LLVM conventions there.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90261/new/

https://reviews.llvm.org/D90261



More information about the llvm-commits mailing list