[PATCH] D90268: [NFC] Use Register in RegisterPressure APIs

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 27 14:45:11 PDT 2020


mtrofin marked an inline comment as done.
mtrofin added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/MachineRegisterInfo.h:635
   /// MCRegUnitIterator).
-  PSetIterator getPressureSets(unsigned RegUnit) const;
+  PSetIterator getPressureSets(Register RegUnit) const;
 
----------------
gjain wrote:
> What is the difference of the RegUnit vs Register? Should we rename the names to be just `Reg` as well?
Not sure, but I'd decouple that from the strong-typing exercise though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90268/new/

https://reviews.llvm.org/D90268



More information about the llvm-commits mailing list