[PATCH] D90108: [MC] Error for .weak/.globl/.local which change the symbol binding

Tue Oct 27 13:21:23 PDT 2020

MaskRay added a comment.

In D90108#2357342 <https://reviews.llvm.org/D90108#2357342>, @nickdesaulniers wrote:

> In D90108#2357336 <https://reviews.llvm.org/D90108#2357336>, @MaskRay wrote:
>
>> We can surely loose it if it turns out to be a wide spreading problem.
>
> The hard part is that regressions tend to get reported AFTER the release when it's too late to fix them.  Maybe a warning for one release, then upgrade to hard error next release gives users more time to find and fix errors, and doesn't result in an unusable release version for anyone?

We other kinds of diagnostics I might agree, for this particular one I think using a warning is a bit unnecessarily conservative.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90108/new/

https://reviews.llvm.org/D90108