[PATCH] D90245: [AMDGPU] Refactor and extend elf-header-flags-mach tests

[Scott Linder via Phabricator via llvm-commits]

scott.linder added inline comments.


================
Comment at: llvm/test/Object/AMDGPU/elf-header-flags-mach.yaml:85
+
+# RUN: sed -e 's/<BITS>/64/' -e 's/<MACH>/AMDGCN_GFX703/' %s | yaml2obj -o %t.o.1
+# RUN: llvm-readobj -S --file-headers %t.o.1 | FileCheck --check-prefixes=ELF-AMDGCN-ALL,ELF-AMDGCN-GFX703 %s
----------------
Replace this with unique suffix (the GFX# is unique)


================
Comment at: llvm/test/Object/AMDGPU/elf-header-flags-mach.yaml:93-99
+# RUN: sed -e 's/<BITS>/64/' -e 's/<MACH>/AMDGCN_GFX801/' %s | yaml2obj -o %t.o.1
+# RUN: llvm-readobj -S --file-headers %t.o.1 | FileCheck --check-prefixes=ELF-AMDGCN-ALL,ELF-AMDGCN-GFX801 %s
+# RUN: obj2yaml %t.o.1 | FileCheck --check-prefixes=YAML-AMDGCN-ALL,YAML-AMDGCN-GFX801 %s
+
+# RUN: sed -e 's/<BITS>/64/' -e 's/<MACH>/AMDGCN_GFX802/' %s | yaml2obj -o %t.o.1
+# RUN: llvm-readobj -S --file-headers %t.o.1 | FileCheck --check-prefixes=ELF-AMDGCN-ALL,ELF-AMDGCN-GFX802 %s
+# RUN: obj2yaml %t.o.1 | FileCheck --check-prefixes=YAML-AMDGCN-ALL,YAML-AMDGCN-GFX802 %s
----------------
Duplicated run lines


================
Comment at: llvm/test/Object/AMDGPU/elf-header-flags-mach.yaml:181
+# ELF-R600-ALL:       Flags [
+# ELF-R600-R600:      EF_AMDGPU_MACH_R600_R600     (0x1)
+# ELF-R600-R630:      EF_AMDGPU_MACH_R600_R630     (0x2)
----------------
Rather than have these as separate blocks, pair them by GFX#, i.e.:

```
ELF-R600-R600: ...
YAML-R600-R600: ...

ELF-R600-R630: ...
YAML-R600-R630: ...
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90245/new/

https://reviews.llvm.org/D90245