[PATCH] D90233: [AArch64] Use DUP for BUILD_VECTOR with few different elements.
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 27 12:13:49 PDT 2020
efriedma added inline comments.
================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:9157
+ !isConstant && NumDifferentLanes >= 1 &&
+ NumDifferentLanes < ((NumElts - NumUndefLanes) / 2) && NumElts >= 4 &&
+ NumDifferentLanes >= NumConstantLanes;
----------------
I think `NumElts >= 4` is redundant? If NumElts == 2, there is no value of NumDifferentLanes that makes this pass.
================
Comment at: llvm/test/CodeGen/AArch64/arm64-vector-insertion.ll:41
+; CHECK-NEXT: mov.s v0[3], v1[0]
; CHECK-NEXT: ret
;
----------------
The test coverage here seems a bit lacking.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90233/new/
https://reviews.llvm.org/D90233
More information about the llvm-commits
mailing list