[PATCH] D90247: [AArch64] Add legalizations for VECREDUCE_SEQ_FADD

Cameron McInally via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 27 11:31:51 PDT 2020


cameron.mcinally added a comment.

In D90247#2357093 <https://reviews.llvm.org/D90247#2357093>, @nikic wrote:

>> Ok, I can build that out. Are we okay with the suboptimal legalization though? I'll wait for that decision before putting more time into this.
>>
>> Or does anyone see a clever fix for the illegal type legalization? It looks like we lost information during widening, so I'm not sure we can get it back in a non-hacky way.
>
> Not sure I follow. If the neutral element is fixed, then the extra fadds should also get folded away. Or is there some additional sub-optimality here?

Ah, I follow now. Didn't catch the connection...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90247/new/

https://reviews.llvm.org/D90247



More information about the llvm-commits mailing list