[PATCH] D90199: [CodeView] Encode signed int values correctly when emitting S_CONSTANTs
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 27 11:29:45 PDT 2020
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
================
Comment at: llvm/test/DebugInfo/COFF/global-constants.ll:66
; OBJ-NEXT: Type: TestEnum (0x1005)
-; OBJ-NEXT: Value: 18446744071562551616
+; OBJ-NEXT: Value: -214700000
; OBJ-NEXT: Name: ENUM_B
----------------
So, we actually already had a test for this, but didn't notice the mismatch during review. Oops. :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90199/new/
https://reviews.llvm.org/D90199
More information about the llvm-commits
mailing list