[PATCH] D70582: [FPEnv][X86] Constrained FCmp intrinsics enabling on X86

[Melanie Blower via Phabricator via llvm-commits]

mibintc added a comment.

bug report



================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:3565
+    // understand if this code is useful for strict nodes.
+    assert(!IsStrict && "Don't know how to expand for strict nodes.");
+
----------------
Got a bug report like this, @pengfei can you please fix this as soon as possible?
I tried to fix it by just removing the assert but that's causing trouble downstream.

[tag] [reply] [−]DescriptionMelanie Blower 2020-10-27 09:29:07 PDT
dmajor added a comment.

After D87528: Enable '#pragma STDC FENV_ACCESS' commit, our bots have a failure on the wasm target, could you please take a look?

test.c:

  double a, b;
  c() {
  #pragma STDC FENV_ACCESS ON
    b == a;
  }

Run `clang -cc1 -triple wasm32-unknown-wasi -emit-obj test.c` (clang needs to be build with `-DLLVM_EXPERIMENTAL_TARGETS_TO_BUILD=WebAssembly`)

Result:

  clang: /home/vm/src/llvm-project/llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:3764: bool (anonymous namespace)::SelectionDAGLegalize::ExpandNode(llvm::SDNode *): Assertion `!IsStrict && "Don't know how to expand for strict nodes."' failed. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70582/new/

https://reviews.llvm.org/D70582