[PATCH] D88977: Reapply [ADT] function_ref's constructor is unavailable if the argument is not callable.

[Stella Stamenova via Phabricator via llvm-commits]

stella.stamenova added a comment.

In D88977#2355654 <https://reviews.llvm.org/D88977#2355654>, @sammccall wrote:

> No, not expected... can you provide more details?
> Is this on a public LLVM buildbot I missed somehow?

It is not a public buildbot - I don't think there is a public buildbot that builds Debug on Windows.

> If not, toolchain information, logs... I guess this is x64?
> There are a few main differences between Debug and Release as I understand: optimization level, -DNDEBUG, debug info. Do you know which it is (e.g. does Release + -DLLVM_ENABLE_ASSERTIONS=On also fail?)

We run a few different permutations locally, including Release (+/- assertions) and Debug (+/- assertions). Of those, the test fails on Debug regardless of assertions and passes on Release regardless of assertions. The setup is essentially a copy of the Windows LLDB bot (http://lab.llvm.org:8011/#/workers/55), but building with VS 2017 directly rather than Ninja.

Here's the log from the failure:

           FAIL: LLVM-Unit :: ADT/Debug/ADTTests.exe/FunctionRefTest.SFINAE (518 of 40375)
           ******************** TEST 'LLVM-Unit :: ADT/Debug/ADTTests.exe/FunctionRefTest.SFINAE' FAILED ********************
           Note: Google Test filter = FunctionRefTest.SFINAE
           
           [==========] Running 1 test from 1 test case.
           
           [----------] Global test environment set-up.
           
           [----------] 1 test from FunctionRefTest
           
           [ RUN      ] FunctionRefTest.SFINAE
           
  ##[error]llvm\unittests\ADT\FunctionRefTest.cpp(57,0): Error : Expected: "not a function"
       1>E:\agent\_work\20\s\llvm\unittests\ADT\FunctionRefTest.cpp(57): error : Expected: "not a function" [e:\agent\_work\20\b\llvm\test\check-llvm.vcxproj]
           
                 Which is: 00007FF66D93C920
           
           To be equal to: returns("boo!")
           
                 Which is: 00007FF66D93C898
           
  ##[error]llvm\unittests\ADT\FunctionRefTest.cpp(58,0): Error : Expected: "number"
       1>E:\agent\_work\20\s\llvm\unittests\ADT\FunctionRefTest.cpp(58): error : Expected: "number" [e:\agent\_work\20\b\llvm\test\check-llvm.vcxproj]
           
                 Which is: 00007FF66D93C994
           
           To be equal to: returns([] { return 42; })
           
                 Which is: 00007FF66D93C8A8
  
  ##[error]llvm\unittests\ADT\FunctionRefTest.cpp(59,0): Error : Expected: "string"
       1>E:\agent\_work\20\s\llvm\unittests\ADT\FunctionRefTest.cpp(59): error : Expected: "string" [e:\agent\_work\20\b\llvm\test\check-llvm.vcxproj]
           
                 Which is: 00007FF66D93CA0C
           
           To be equal to: returns([] { return "hello"; })
           
                 Which is: 00007FF66D93C8B0
           
           [  FAILED  ] FunctionRefTest.SFINAE (1 ms)




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88977/new/

https://reviews.llvm.org/D88977