[PATCH] D88406: [LiveDebugValues][InstrRef][2/2] Emit entry value variable locations

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added inline comments.


================
Comment at: llvm/test/DebugInfo/ARM/entry-value-multi-byte-expr.ll:2
 ; RUN: llc -debug-entry-values -filetype=asm -o - %s | FileCheck %s
+; RUN: llc -force-instr-ref-livedebugvalues=1 -debug-entry-values -filetype=asm -o - %s | FileCheck %s
 
----------------
jmorse wrote:
> djtodoro wrote:
> > is the `-force-instr-ref-livedebugvalues=1` equivalent to the `-experimental-debug-variable-locations`?
> Not quite, the truth table is:
> 
> |   | Produce DBG_INSTR_REF in isel? | Use InstrRefBasedLDV? |
> | no options | False | False |
> | -force-isntr-ref-livedebugvalues=1 | False | True |
> | -experimental-debug-variable-locations | True | True |
> 
> Thus, this option lets you can explore how InstrRefBasedLDV behaves compared to VarLocBasedLDV without using all the other instruction referencing work.  The two implementations should produce the same output at all times, aside from a few limitations, see the "Testing and Validation" section in:
> 
>   http://lists.llvm.org/pipermail/llvm-dev/2020-June/142368.html
> 
> (There are still a couple of minor bugs hanging around InstrRefBasedLDV, and this is helping me hunt them).
Oh, I see.. It will be in after D88405 is landed.

Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88406/new/

https://reviews.llvm.org/D88406