[PATCH] D90171: [SVE] Fix TypeSize warning in RuntimePointerChecking::insert

[Joe Ellis via Phabricator via llvm-commits]

joechrisellis added inline comments.


================
Comment at: llvm/test/Analysis/LoopAccessAnalysis/runtime-pointer-checking-insert-typesize.ll:1
+; RUN: opt -loop-load-elim -mtriple=aarch64-linux-gnu -mattr=+sve < %s >/dev/null 2>%t
+; RUN: FileCheck --check-prefix=WARN --allow-empty %s <%t
----------------
fhahn wrote:
> Ideally the tests in this directory would only use `-loop-accesses -analyze` and no transformation passes. Is that possible? Also, is `-mattr=+sve` needed?
> 
> If `loop-load-elimination` is required, the test should probably go there. Also it might be good to just have all scaleable tests in a single file in the directory>
Thanks for the pointers!

> Ideally the tests in this directory would only use -loop-accesses -analyze and no transformation passes. Is that possible? Also, is -mattr=+sve needed?

Ah okay -- turns out we can just use `-loop-accesses -analyze` for the same result. Fixed this.

> If loop-load-elimination is required, the test should probably go there.

It's not required. :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90171/new/

https://reviews.llvm.org/D90171