[PATCH] D90019: [yaml2obj] - Add a way to override the sh_addralign field of a section.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 27 02:22:54 PDT 2020


jhenderson accepted this revision.
jhenderson added a comment.

One nit, otherwise LGTM.



================
Comment at: llvm/test/tools/yaml2obj/ELF/override-shaddralign.yaml:25
+    Type:         SHT_PROGBITS
+    AddressAlign: 0x10
+    ShAddrAlign:  0x1111111111111111
----------------
I'd explicitly set this to be something larger than the size of the ELF header, e.g. 0x80, to demonstrate that alignment has actually occurred here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90019/new/

https://reviews.llvm.org/D90019



More information about the llvm-commits mailing list