[PATCH] D89304: [llvm-readelf] - Implement --section-details option.

Tue Oct 27 02:17:14 PDT 2020

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, thanks.

================
Comment at: llvm/test/tools/llvm-readobj/ELF/section-details.test:75
+#  GNU64-NEXT:       [0000000080000000]: EXCLUDE
+#  GNU64-NEXT:  [15] known_and_unknown
+#  GNU64-NEXT:       PROGBITS          0000000000000000 0000000000000046  0
----------------
grimar wrote:
> jhenderson wrote:
> > Is UNKNOWN printed for "known" OS/Processor specific flags with GNU readelf?
> GNU readelf prints the following for sh_flags = 0xffffffffffffffff:
> 
> 
> ```
> [ffffffffffffffff]: WRITE, ALLOC, EXEC, MERGE, STRINGS, INFO LINK, LINK ORDER, OS NONCONF, GROUP, TLS, COMPRESSED, GNU_MBIND, EXCLUDE, OS (000000000ef00000), PROC (0000000070000000), UNKNOWN (ffffffff000ff008)
> ```
> 
> I.e. it prints "OS", "PROC" and "UNKNOWN" separatelly. I've updated implementation to follow.
(grumbles quietly about SHF_EXCLUDE usurping a bit from the processor-specific range making the PROC value not match SHF_MASK_PROC...)

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89304/new/

https://reviews.llvm.org/D89304