[PATCH] D89489: [InterleaveAccess] Recognize Interleave loads through binary operations
Dave Green via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 27 02:16:41 PDT 2020
dmgreen added a comment.
Added InterleavedAccess and addressed other review comments.
================
Comment at: llvm/lib/CodeGen/InterleavedAccessPass.cpp:295-297
SmallVector<ShuffleVectorInst *, 4> Shuffles;
SmallVector<ExtractElementInst *, 4> Extracts;
+ SmallSetVector<ShuffleVectorInst *, 4> BinOpShuffles;
----------------
spatel wrote:
> Should all of these be SmallSetVector?
I had to remind myself why this was needed. We need to ensure the BinOpShuffles are only replaced once, even if both operands of the binop are the same interleaving load.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89489/new/
https://reviews.llvm.org/D89489
More information about the llvm-commits
mailing list