[PATCH] D90126: [AArch64] Remove AArch64ISD::NOT, use vnot instead

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 27 01:16:55 PDT 2020


dmgreen added a comment.

In D90126#2353874 <https://reviews.llvm.org/D90126#2353874>, @RKSimon wrote:

> No strong opinion on the cmtst regression - but adding an equivalent canonicalization in DAGCombine might still be worth it if we can generate such a pattern in DAG somehow.

Thanks for the suggestions. I feel like if the pattern was non-canonical then it's unlikely to cause problems. the full pattern is `or(and(not(a), b), and(a, c))` for the bsl and `not(icmp eq(and(d, e), 0))` for the cmtst, so unfortunately the not's end up simplifying away.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90126/new/

https://reviews.llvm.org/D90126



More information about the llvm-commits mailing list