[PATCH] D86673: [StackColoring] Conservatively merge Variable in catch(Variable)

[Xiang Zhang via Phabricator via llvm-commits]

xiangzhangllvm added inline comments.


================
Comment at: llvm/test/CodeGen/X86/StackColoring-first-use-in-catch.mir:7
+#
+#// Compile with "clang-cl -m32 -O2 -EHs test.cpp"
+#__attribute__((noinline,nothrow,weak)) void escape(int *p) { }
----------------
LuoYuanke wrote:
> Since you have an .cpp or .ll to duplicate the bug, do you still need .mir test case?
Yes, .mir test is better, I used "-run-pass=stack-coloring" here.
 it let us just test the "stack-coloring" changing, not affected by other optimizations.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86673/new/

https://reviews.llvm.org/D86673