[PATCH] D88717: [obj2yaml] [yaml2obj] Add yaml support for SHT_LLVM_BB_ADDR_MAP section.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 26 23:43:30 PDT 2020
grimar added inline comments.
================
Comment at: llvm/test/tools/yaml2obj/ELF/bb-addr-map.yaml:114
+ Type: SHT_LLVM_BB_ADDR_MAP
+ Entries:
+ - BBEntries:
----------------
grimar wrote:
> I think you should be able to write just `Entries: []`. No need to provide more input data than needed.
> The same for Context: a single byte should be enough for this test.
Or even: `Content: ""`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88717/new/
https://reviews.llvm.org/D88717
More information about the llvm-commits
mailing list