[PATCH] D89432: [llvm-elfabi] Emit ELF .dynsym and .dynamic sections

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/InterfaceStub/ELFObjHandler.cpp:111
+private:
+  llvm::SmallVector<Elf_Sym, 64> Symbols;
+
----------------
64 is too large. This costs 24*64 bytes to the class. 0 may be fine assuming you always need a dynamic allocation (which is not a big deal)


================
Comment at: llvm/lib/InterfaceStub/ELFObjHandler.cpp:304
+    // Poplulate dynamic table.
+    size_t DynSymIndex = DynTab.Content.addAddr(DT_SYMTAB, 0);
+    size_t DynStrIndex = DynTab.Content.addAddr(DT_STRTAB, 0);
----------------
Linkers don't read DT_SYMTAB or DT_STRTAB.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89432/new/

https://reviews.llvm.org/D89432