[PATCH] D90106: [JumpThreading] Set edge probabilities when creating basic blocks

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 26 15:47:36 PDT 2020


MaskRay added a comment.

I've debugged this two weeks ago:)

> Now, we rarely remove entries from this map, so if we happen to ...

Thanks for narrowing it down to the issue! LGTM

Do you know whether we have missed some BranchProbabilityInfo::eraseBlock calls? Why is BasicBlockCallbackVH::deleted() not effective when some BasicBlock's are removed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90106/new/

https://reviews.llvm.org/D90106



More information about the llvm-commits mailing list