[PATCH] D86673: [StackColoring] Conservatively merge Variable in catch(Variable)

[Chang Lin via Phabricator via llvm-commits]

clin1 added inline comments.


================
Comment at: llvm/lib/CodeGen/StackColoring.cpp:706
+          // with object V which may call destructor after write &(&X).
+          //
+          // The loader of &(&X) is the first LOAD MI in EHPad. Some like:
----------------
It might be worth explaining here that the runtime writes to X outside of the user code, which is why we don't know the exact start of the lifetime.
Question: Why does a memory read start a stack value lifetime---shouldn't it be a write? And if we don't find a write, then the coloring should be conservative?



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86673/new/

https://reviews.llvm.org/D86673