[PATCH] D90008: [NFC] Use [MC]Register in RegAllocPBQP & RegisterCoalescer

Gaurav Jain via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 26 14:28:52 PDT 2020


gjain added inline comments.


================
Comment at: llvm/lib/CodeGen/RegisterCoalescer.cpp:1522
   for (unsigned i = 0, e = NewMIImplDefs.size(); i != e; ++i) {
-    unsigned Reg = NewMIImplDefs[i];
+    Register Reg = NewMIImplDefs[i];
     for (MCRegUnitIterator Units(Reg, TRI); Units.isValid(); ++Units)
----------------
mtrofin wrote:
> MCRegUnitIterator takes MCRegisters, so either Reg.asMCReg(), or NewMIImplDefs is MCRegister values (if the latter is correct)
Thanks NewMIImplDefs should be MCRegister values. Fixed now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90008/new/

https://reviews.llvm.org/D90008



More information about the llvm-commits mailing list