[PATCH] D89817: [DebugInfo] Expose Fortran array debug info attributes through DIBuilder.

Chih-Ping Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 26 13:05:09 PDT 2020


cchen15 marked an inline comment as done.
cchen15 added inline comments.


================
Comment at: llvm/include/llvm/IR/DIBuilder.h:508
+    ///                     Fortran array. Typically a DIExpression* or
+    ///                     a DIVariable*.
     DICompositeType *createArrayType(uint64_t Size, uint32_t AlignInBits,
----------------
aprantl wrote:
> We could make this still strongly typed by either having two variants of the function or by using a `PointerUnion<DIExpression, DIVariable>` here.
Thanks for pointing this out.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89817/new/

https://reviews.llvm.org/D89817



More information about the llvm-commits mailing list