[PATCH] D89817: [DebugInfo] Expose Fortran array debug info attributes through DIBuilder.

[Chih-Ping Chen via Phabricator via llvm-commits]

cchen15 added a comment.

In D89817#2353822 <https://reviews.llvm.org/D89817#2353822>, @aprantl wrote:

>> We can do that, but then the debugger would need to work a bit harder in order to get a constant, doesn't it? I don't feel strongly either way. If you do want it done the way you prefer, please let me know and I will make the change.
>
> That's an interesting point. Do we emit different DWARF FORMs for constant vs constant DIExpression? An elegant solution would be to recognize constant DIExpressions in AsmPrinter (DIExpression::isConstant) and emit the same DWARF FORM we would emit for an IR constant if the expression is a constant.

This optimization is orthogonal to the change proposed here, IMHO. I'd prefer keep this patch to DIBuilder, and do that optimization in a separate patch. Would that be ok with you?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89817/new/

https://reviews.llvm.org/D89817