[PATCH] D90108: [MC] Error for .weak/.globl/.local which change the symbol binding

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 26 11:49:09 PDT 2020


psmith added a comment.

Personally I'd err on the side of consistency with binutils. If they are happy to go to an error then we can. If they aren't then I recommend that we warn rather than error as we risk breaking builds for working software and it isn't always easy to get source code fixed. Not got a strong opinion though so happy to go with the consensus.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90108/new/

https://reviews.llvm.org/D90108



More information about the llvm-commits mailing list