[PATCH] D89650: [DSE] Remove noop stores after killing stores for a MemoryDef.

Zoe Carver via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 26 09:53:44 PDT 2020


zoecarver added a comment.

This LGTM. I wonder if there are any cases where passing the killing memory def in `storeIsNoop` to `storeIsNoop` would benefit us. I can't think of one off the top of my head, because it doesn't really matter what order the noop stores come in. But maybe if there was a weird block ordering. I'll see if I can come up with an example.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89650/new/

https://reviews.llvm.org/D89650



More information about the llvm-commits mailing list