[PATCH] D90126: [AArch64] Remove AArch64ISD::NOT, use vnot instead

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 26 09:41:31 PDT 2020


RKSimon added a comment.

No strong opinion on the cmtst regression - but adding an equivalent canonicalization in DAGCombine might still be worth it if we can generate such a pattern in DAG somehow.



================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:9608
+      return DAG.getNode(ISD::XOR, dl, VT, Fcmeq,
+                         DAG.getAllOnesConstant(dl, VT));
     }
----------------
Use DAG.getNOT()?


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:9648
+    return DAG.getNode(ISD::XOR, dl, VT, Cmeq,
+                       DAG.getAllOnesConstant(dl, VT));
   }
----------------
Use DAG.getNOT()?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90126/new/

https://reviews.llvm.org/D90126



More information about the llvm-commits mailing list