[PATCH] D89993: [GWP-ASan] Refactor memory mapping functions

[Kostya Kortchinsky via Phabricator via llvm-commits]

cryptoad updated this revision to Diff 300679.
cryptoad marked 5 inline comments as done.
cryptoad added a comment.
Herald added a subscriber: phosek.

Addressing review comments:

- tried to strike a middle ground between name suggestions, settled on: ```void *reserveGuardedPool(size_t Size);

void allocateInGuardedPool(void *Ptr, size_t Size) const;
void deallocateInGuardedPool(void *Ptr, size_t Size) const;
void unreserveGuardedPool();```

- added comments and clarifications about API contracts
- used anonymous namespace instead of `static`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89993/new/

https://reviews.llvm.org/D89993

Files:
  compiler-rt/lib/gwp_asan/guarded_pool_allocator.cpp
  compiler-rt/lib/gwp_asan/guarded_pool_allocator.h
  compiler-rt/lib/gwp_asan/platform_specific/guarded_pool_allocator_posix.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89993.300679.patch
Type: text/x-patch
Size: 11223 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201026/f64f69da/attachment-0001.bin>