[PATCH] D80695: [mlir] Convert raw data in dense element attributes for big-endian machines.

[Haruki Imai via Phabricator via llvm-commits]

imaihal marked 5 inline comments as done.
imaihal added inline comments.


================
Comment at: mlir/lib/IR/AsmPrinter.cpp:1509
+    ArrayRef<char> inRawData = attr.getRawData();
+    // Convert endianess in big-endian(BE) machines. `inRawData` is BE in BE
+    // machines. It is converted here to print in LE format. Not converted
----------------
rriddle wrote:
> If this machine is already little-endian, can we remove the redundant copy?
I couldn't find good way without checking system_endianness to avoid redundant copy for little endian.  Little endian code is the same with original one. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80695/new/

https://reviews.llvm.org/D80695