[PATCH] D89949: [yaml2obj][obj2yaml] - Teach tools to work with regular archives.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 26 04:26:30 PDT 2020
grimar added inline comments.
================
Comment at: llvm/tools/obj2yaml/archive2yaml.cpp:66
+
+ const bool HasPaddingByte = (Size & 1) && Buffer.size() > Size;
+ if (HasPaddingByte)
----------------
jhenderson wrote:
> Is there testing for the `Buffer.size() > Size` aspect of this? In other words, showing that if the member ends at the end of the file, no padding.
No. I've added the test.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89949/new/
https://reviews.llvm.org/D89949
More information about the llvm-commits
mailing list