[PATCH] D89170: [AMDGPU] Use flat scratch instructions where available

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:4308-4311
+  if (Reg.isPhysical())
+    return DRC->contains(Reg);
+
+  const TargetRegisterClass *RC = MRI.getRegClass(Reg);
----------------
Unrelated change?


================
Comment at: llvm/lib/Target/AMDGPU/SIRegisterInfo.cpp:782-784
+  bool IsOffsetLegal = IsFlat
+      ? !TII->isLegalFLATOffset(MaxOffset, AMDGPUAS::PRIVATE_ADDRESS, true)
+      : !SIInstrInfo::isLegalMUBUFImmOffset(MaxOffset);
----------------
This looks backwards with the negated conditions


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89170/new/

https://reviews.llvm.org/D89170